[WIP等所有语言][Darabonba 2.0]rebuild retry policy && support retry for throttling e… #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
=======================================
Coverage 53.84% 53.84%
=======================================
Files 1 1
Lines 455 455
Branches 94 94
=======================================
Hits 245 245
Misses 150 150
Partials 60 60 ☔ View full report in Codecov by Sentry. |
yndu13
changed the title
peze
reviewed
May 6, 2024
| accessDeniedDetail = defaultAny(err.AccessDeniedDetail, err.accessDeniedDetail), | ||
| }; | ||
| var code = defaultAny(err.Code, err.code); | ||
| if (Util.equalString(`${code}`, 'Throttling') || Util.equalString(`${code}`, 'Throttling.User') || Util.equalString(`${code}`, 'Throttling.Api')) { |
peze
reviewed
May 6, 2024
| retryAfter = OpenApiUtil.getThrottlingTimeLeft(__response.headers), | ||
| requestId = `${requestId}`, | ||
| }; | ||
| } else if (Util.is4xx(__response.statusCode)) { |
There was a problem hiding this comment.
这里也可以用 statusCodeSample >= 400 && statusCodeSample < 500判断
peze
reviewed
May 6, 2024
| accessDeniedDetail = defaultAny(err.AccessDeniedDetail, err.accessDeniedDetail), | ||
| }; | ||
| var code = defaultAny(err.Code, err.code); | ||
| if (Util.equalString(`${code}`, 'Throttling') || Util.equalString(`${code}`, 'Throttling.User') || Util.equalString(`${code}`, 'Throttling.Api')) { |
peze
reviewed
May 6, 2024
| retryAfter = OpenApiUtil.getThrottlingTimeLeft(__response.headers), | ||
| requestId = `${requestId}`, | ||
| }; | ||
| } else if (Util.is4xx(__response.statusCode)) { |
peze
reviewed
May 6, 2024
| description = `${defaultAny(err.Description, err.description)}`, | ||
| requestId = `${requestId}`, | ||
| }; | ||
| } | ||
| } | ||
| if (Util.equalString(bodyType, 'binary')) { |
peze
reviewed
May 6, 2024
| @@ -542,14 +593,35 @@ api doROARequestWithForm(action: string, version: string, protocol: string, meth | |||
| if (Util.is4xx(__response.statusCode) || Util.is5xx(__response.statusCode)) { | |||
peze
reviewed
May 6, 2024
| }; | ||
| var requestId = defaultAny(err.RequestId, err.requestId); | ||
| var code = defaultAny(err.Code, err.code); | ||
| if (Util.equalString(`${code}`, 'Throttling') || Util.equalString(`${code}`, 'Throttling.User') || Util.equalString(`${code}`, 'Throttling.Api')) { |
peze
reviewed
May 6, 2024
| retryAfter = OpenApiUtil.getThrottlingTimeLeft(__response.headers), | ||
| requestId = `${requestId}`, | ||
| }; | ||
| } else if (Util.is4xx(__response.statusCode)) { |
peze
reviewed
May 6, 2024
| accessDeniedDetail = defaultAny(err.AccessDeniedDetail, err.accessDeniedDetail), | ||
| }; | ||
| var requestId = defaultAny(err.RequestId, err.requestId); | ||
| var code = defaultAny(err.Code, err.code); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rror